Scipaper/Frontend
5
0
Fork 0
Code Issues 15 Pull Requests Packages Projects Releases Wiki Activity

create/radioComponent #33

Closed
salar.sali wants to merge 1 commits from create/radioComponent into develop
pull from: create/radioComponent
merge into: Scipaper:develop
Conversation 4 Commits 1 Files Changed -
salar.sali commented 2022-07-28 11:24:23 +00:00 (Migrated from 85.143.176.51:3000)
Copy Link

Issue #15

Issue #15
decamel commented 2022-07-28 11:35:15 +00:00 (Migrated from 85.143.176.51:3000)
Copy Link

You don't need label property. It is already inside 'nested' props.

This is not good:

type="Radio"

VALUE IS NOT SAME AS LABEL!!

value={label}
You don't need `label` property. It is already inside 'nested' props. This is not good: ```jsx type="Radio" ``` VALUE IS NOT SAME AS LABEL!! ```jsx value={label} ```
decamel commented 2022-07-28 11:38:00 +00:00 (Migrated from 85.143.176.51:3000)
Copy Link

Why do you have Checkbox changes inside this commit?

Why do you have `Checkbox` changes inside this commit?
decamel commented 2022-07-29 07:02:49 +00:00 (Migrated from 85.143.176.51:3000)
Copy Link

Rejected due to unrelated changes inside a commit.

Rejected due to unrelated changes inside a commit.
decamel commented 2022-08-05 13:24:21 +00:00 (Migrated from 85.143.176.51:3000)
Copy Link

Closed due to merge in #51. Not needed

Closed due to merge in #51. Not needed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
behnam maximus mishkiss salar.sali weissmall
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Scipaper/Frontend#33
No description provided.
Delete Branch "create/radioComponent"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?