A checkbox with a label #30

2022-07-27T16:45:18Z

salar.sali commented

2022-07-27 16:45:18 +00:00

(Migrated from 85.143.176.51:3000)

issue # 14

decamel commented

2022-07-28 13:46:41 +00:00

(Migrated from 85.143.176.51:3000)

We missed one thing, @salar.sali

<>
  <Checkbox 
    value="very important value" 
    onChange={(value) => {
      /*we expect value or null here I guess*/
      /* it is better to remove this property from Props type*/
  }} />
</>

We missed one thing, @salar.sali ```jsx <> <Checkbox value="very important value" onChange={(value) => { /*we expect value or null here I guess*/ /* it is better to remove this property from Props type*/ }} /> </> ```

salar.sali commented

2022-07-28 15:31:50 +00:00

(Migrated from 85.143.176.51:3000)

working on it..
i will push it to the same branch and then make a new pull request

working on it.. i will push it to the same branch and then make a new pull request

decamel commented

2022-07-29 05:54:50 +00:00

(Migrated from 85.143.176.51:3000)

<label htmlFor={props.label}>{props.label}</label>

You should improve your html knowledge.
labels for property accepts identifier of element.

Either use:

<label for="username">Enter your username:</label>
<input id="username">

Or:

<label>Do you like peas?
  <input type="checkbox" name="peas">
</label>

```jsx <label htmlFor={props.label}>{props.label}</label> ``` You should improve your html knowledge. labels `for` property accepts identifier of element. Either use: ```html <label for="username">Enter your username:</label> <input id="username"> ``` Or: ```html <label>Do you like peas? <input type="checkbox" name="peas"> </label> ```

decamel commented

2022-07-29 05:56:07 +00:00

(Migrated from 85.143.176.51:3000)

Pls, use our branches naming convention:
feature/*short name of task*
fix/*short fix essence*
etc.

Pls, use our branches naming convention: `feature/*short name of task*` `fix/*short fix essence*` etc.

decamel commented

2022-07-29 07:02:01 +00:00

(Migrated from 85.143.176.51:3000)

Please, checkout the way of building.
And take a look at the created Story.

Please, checkout the way of building. And take a look at the created Story.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Scipaper/Frontend#30